$instring = "This-is-my-string";

$outstring = $instring;

$outstring =~ s/-/_/g;

print $outstring;