in reply to Re: How do you critique another person's code?
in thread How do you critique another person's code?
I agree. Remember this is not a personal attack, only a critiquing of his code. Calmly let him know that the comments are unprofessional and reflect badly on him and the company. Let his manager reprimand him for the poor choice in comments that's his job, concentrate on the code. Remind him that well used comments and understandable variables help bring real understanding as to what the code is doing. If you feel that the code needs to be rewritten show them why.
From the looks of it he needs mentoring. I am one who likes to give people a chance, but I am not suggesting that you take that job. Does he have potential? Yes, we all do. If they don't already have it suggest a code review process. bmcatt has an excellent out line. This is an excellent site for code review as well.
From the looks of it he needs mentoring. I am one who likes to give people a chance, but I am not suggesting that you take that job. Does he have potential? Yes, we all do. If they don't already have it suggest a code review process. bmcatt has an excellent out line. This is an excellent site for code review as well.
Ideas for designing and conducting code reviews at TechRepublic has links to articles and tips from readers. These have some good info, you may have to sign up at the site, it's free. If you have problems let me know and I'll get you the articles.
Good luck,
Brad
|
---|
Replies are listed 'Best First'. | |
---|---|
Re: Re: Re: How do you critique another person's code?
by merlyn (Sage) on Dec 20, 2001 at 22:29 UTC | |
by scott (Chaplain) on Dec 21, 2001 at 05:44 UTC | |
by merlyn (Sage) on Dec 21, 2001 at 07:19 UTC | |
by scott (Chaplain) on Dec 22, 2001 at 04:46 UTC | |
by dragonchild (Archbishop) on Dec 20, 2001 at 22:52 UTC | |
by Gyro (Monk) on Dec 21, 2001 at 01:09 UTC |
In Section
Meditations