in reply to DBI conditional insert (and things of those nature)
1) Most databases support unique id keys for tables. If you set up the employee database that the ID must be unique, and then try to insert a conflicting record, you'll get an error from DBI. Otherwise, it's probably just as easy to use either method; since rows() is a DBI level and not database level, it'll be portable anyway.
2) Instead of worrying about quotes, you should use placeholders in the DBI statement, such as:
When you use placeholders, all variables are quoted appropriately to escape \' and \" constructs as well as other characters that might cuase the DB trouble. This is better than having to roll out your own.$SQL = "INSERT INTO EMPLOYEE ( EMPLOYEE_NUMBER, FIRST_NAME, LAST_NAME, INFORMATION_DATE +) VALUES (?, ?, ?, SYSDATE)" +; $sth = $dbh->prepare($SQL); $sth->execute( $employee_number, $first_name, $last_name );
Finally, not asked, but you're checking for errors in a very odd way. DBI statements don't die, so using eval won't catch errors. Instead, you should check the error status via the $DBI::errstr variable, and do this after every "prepare" and "execute" statement, such as
Or, in your case, since you want to let the user know of a problem to the broswer, that execute can be written as:$SQL = "INSERT INTO EMPLOYEE ( EMPLOYEE_NUMBER, FIRST_NAME, LAST_NAME, INFORMATION_DATE +) VALUES (?, ?, ?, SYSDATE)" +; $sth = $dbh->prepare($SQL) or die $DBI::errstr; $sth->execute( $employee_number, $first_name, $last_name ) or die $D +BI::errstr;
(or some control similar to that.)if ( !$sth->execute( $employee_number, $first_name, $last_name ) ) { print "Could not insert into database: ", $DBI::errstr, "\n"; return; }
-----------------------------------------------------
Dr. Michael K. Neylon - mneylon-pm@masemware.com
||
"You've left the lens cap of your mind on again, Pinky" - The Brain
"I can see my house from here!"
It's not what you know, but knowing how to find it if you don't know that's important
|
---|
Replies are listed 'Best First'. | |
---|---|
Re: Re: DBI conditional insert (and things of those nature)
by lachoy (Parson) on Jan 26, 2002 at 00:36 UTC | |
by Masem (Monsignor) on Jan 26, 2002 at 03:04 UTC | |
by lachoy (Parson) on Jan 26, 2002 at 09:51 UTC | |
by Masem (Monsignor) on Jan 26, 2002 at 17:53 UTC | |
by little (Curate) on Jan 26, 2002 at 18:52 UTC |
In Section
Seekers of Perl Wisdom