Re: Find a file in a list of directories

in reply to Find a file in a list of directories

more compact version of your code. And you should use '-e' test instead of '-t'

#!/usr/bin/perl
sub FileFinder {
   my ($target, @dir) = @_;
   return (grep {-e $_} map {"$_/$target"} @dir)[0];
}
 
open(F, FileFinder('FileFinder.pl', qw(some/ dirs/ ./)) || die "File n
+ot found") or die $!;
[download]

Comment on Re: Find a file in a list of directories Download Code

Replies are listed 'Best First'.
Re: Re: Find a file in a list of directories by demerphq (Chancellor) on May 06, 2002 at 16:50 UTC
IMO in general grep and map shouldn't be chained together, map can do greps job without having retraverse the array. `return (map{-e "$_/$target" ? "$_/$target" : ()} @dir)[0];` [download] And frankly why bother with map and grep at all? This is much more efficient. `sub FileFinder { my $target=shift; -e "$_/$target" && return "$_/$target" foreach @_; undef }` [download] Oh and before the premature optimization police arrest me, remember that we are searching a filesystem (possible remote etc) here. That call to -e could take a while and if we have to do more of them than we really need to then we could end up wasting a lot of time. Adjust the file test to your taste ;-) Yves / DeMerphq --- Writing a good benchmark isnt as easy as it might look.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re: Re: Find a file in a list of directories
by demerphq (Chancellor) on May 06, 2002 at 16:50 UTC

return (map{-e "$_/$target" ? "$_/$target" : ()} @dir)[0];
[download]

sub FileFinder {
  my $target=shift;
  -e "$_/$target" && return "$_/$target" foreach @_;
  undef 
}
[download]

Adjust the file test to your taste ;-)

Yves / DeMerphq
---
Writing a good benchmark isnt as easy as it might look.

[reply]
[d/l]
[select]

In Section Cool Uses for Perl