http://www.perlmonks.org?node_id=484575


in reply to Re^4: A refactoring trap
in thread A refactoring trap

No it still works with chomp

To understand why this works, take a look at the return value for chomp. Hint: it's not the string with newlines missing.

The problem with while (my $line = <DATA>) {} is real, it's just obscure. As hinted, it only happens when you get a line with a false value and no newline. Sometimes this happens at the end of a file. Sometimes it happens for other reasons. It usually doesn't cause any actual problems, but certainly is something to look out for.

Replies are listed 'Best First'.
Re^6: A refactoring trap
by adrianh (Chancellor) on Aug 18, 2005 at 11:46 UTC
    The problem with while (my $line = <DATA>) {} is real, it's just obscure

    ARRRRGH! :-)

    As has already been pointed out this hasn't been a problem for some time. Perl automatically adds the defined for you, as you can easily see by running:

    a% perl -MO=Deparse -e 'while (my $line = <DATA>) {}'  
while (defined(my $line = <DATA>)) {
    ();
}
__DATA__
-e syntax OK

    [download]

    This hasn't been a problem for Perl for quite some time, and I wish people wouldn't keep saying it is ;-)

[reply]
[d/l]
[select]
      this hasn't been a problem for some time. Perl automatically adds the defined for you

      Aye, I wrongly thought this only happened in the case of while (<FH>) {}. Sorry about the confusion.

[reply]
[d/l]

In Section Meditations