(Ovid) Re: CGI.pm file upload freaking me out

[Ovid]

There are a few problems with what I see above. First, it looks like your code is incomplete. Did you try to "pare it down" when posting? Amongst other things, you have while (<$file_name>), but you never opened $file_name.

Problems with the following snippet:

open (F, ">$photo_save_name");

while (<$file_name>) {
    print F;
}

• You should test whether or not "open" was successfful.
• As I mentioned, you didn't open $file_name.
• Further, you haven't reset $/, so after you open $file_name, you'll be breaking $file_name on the newlines.
• while (<$file_name>) should be written as:

  while ( read( $file_handle, $buffer, BUFFER_SIZE ) ) {
  

Those are the major things that I see, so perhaps you can work on those, first.

Incidentally, I share your pain about CGI.pm and file uploads. One thing you might want to try is a new install and ensure that you've installed ALL of the modules with it. Not upgrading all of them can have unpredictable results (I speak from experience).

Cheers,
Ovid

Update: Of course he didn't open $file_handle. He didn't need to. I've written enough upload scripts that I should have paid attention. I am so embarrassed. :)

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.