Re: On maintaining old code and the battle of styles...

[Biker]

• Do you intend to keep the ownership for 'the future'? -- Apply your own style whenever you make changes and/or additions. Potentially, work through the module applying your style all over. (You will learn a lot more about the module in the process.)
• Do you think you will soon hand this module over to someone else? -- Follow the same style as the original author.
• Do you think the module is mature enough to not need any more significant development? -- Consider following the same style as the original author.

---

Everything went worng, just as foreseen.

[pdcawley]

Please, if you do decide to change the style, then change it everywhere at once. Especially the parameter passing stuff, where consistency is really important. I've had to maintain code that was written in a mishmash of styles and it's just painful.