in reply to Re^2: Is there a way to avoid copy function from overwriting old contents?
in thread Is there a way to avoid copy function from overwriting old contents?
Apart from confusing copying with appending, and trying to overwrite a file that's already open for appending, this code can be made to work with the changes below.#!/usr/bin/perl use strict; use warnings; use File::Copy; #change this to 0 and execute, then back to one and execute my $value0 = 1; my $value1 ='true'; ## marmot: open for overwriting open (INFO, "> tmp"); print INFO "this is simple\n"; close (INFO); ## marmot: open RESULT_LOG for appending open (FILE, ">> RESULT_LOG") ; print FILE " STATUS obtained : $value1\n"; # If true then copies the information to the RESULT_LOG ## marmot: translation --> if $value0 is true, overwrite RESULT_LOG wi +th tmp. ## By the way, <FILE>, which is RESULT_LOG, is still open for +appending, ## so this is probably a bad idea. if ($value0 == 1) { copy("tmp","RESULT_LOG");} ## marmot: Otherwise, append RESULT_LOG with text. else { print FILE "Check keyword supplied\n"; } close(FILE);
if ($value0 == 1) { open INFO, "<tmp"; print FILE <INFO>; # Appends to RESULT_LOG else { print FILE "Check keyword supplied\n"; } close(FILE); close(INFO);
I realize this is just a snippet to show what you're trying to accomplish, but I have to wonder if it makes sense to open 'tmp' and write text to it, when you're just going to append it to another file later. Why not put this information in a variable and keep it around until you need to write it to a file?
Also, for the sake of your own clarity, you might want to give your file handles names that are closer to the file names they represent, or perhaps the functions they perform. E.g.,
open TMP, "<tmp"; open LOG, ">>RESULT_LOG"; open RESULTS, ">>RESULT_LOG";
--marmot
|
---|
Replies are listed 'Best First'. | |
---|---|
Re^4: Is there a way to avoid copy function from overwriting old contents?
by justkar4u (Novice) on Apr 12, 2011 at 18:01 UTC | |
by furry_marmot (Pilgrim) on Apr 12, 2011 at 19:59 UTC |
In Section
Seekers of Perl Wisdom