Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

(Ovid) Re: How do you critique another person's code?

by Ovid (Cardinal)
on Dec 19, 2001 at 22:47 UTC ( #133209=note: print w/replies, xml ) Need Help??

Help for this page

Select Code to Download

  1. or download this
    if ($file1[0] eq $dealerno)
      @file2[$cnts++] = $file1[9];
      @file2[$cnts++] = $file1[10];
  2. or download this
    if ($file1[0] eq $dealerno)
      @file2[0..10] = @file1[0..10];
  3. or download this
    Scalar value @file2[$cnts++] better written as @file2[$cnts++] at -foo line 327.