<?xml version="1.0" encoding="windows-1252"?>
<node id="1016966" title="Re^3: Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displays" created="2013-02-04 11:12:43" updated="2013-02-04 11:12:43">
<type id="11">
note</type>
<author id="968231">
Athanasius</author>
<data>
<field name="doctext">
&lt;p&gt;Can&amp;rsquo;t speak for [jdporter], but to my way of thinking the loops (C-style instead of foreach-style) are the least of the problems. To &lt;i&gt;my&lt;/i&gt; old eyes the major issues are:&lt;/p&gt;

&lt;ol&gt;
&lt;li&gt;&lt;p&gt;&lt;c&gt;$mode&lt;/c&gt; never changes, but it&amp;rsquo;s re-tested each time through the main loop.&lt;/p&gt;&lt;/li&gt;
&lt;li&gt;&lt;p&gt;The code is monolithic and should be refactored into subroutines (one for each mode).&lt;/p&gt;&lt;/li&gt;
&lt;li&gt;&lt;p&gt;&lt;c&gt;use warnings;&lt;/c&gt; and &lt;c&gt;use strict;&lt;/c&gt; are missing, and all the variables are global.&lt;/p&gt;&lt;/li&gt;
&lt;/ol&gt;

&lt;p&gt;Hope that helps,&lt;/p&gt;

&lt;div class="pmsig"&gt;&lt;div class="pmsig-968231"&gt;
&lt;p&gt;
&lt;table width="100%"&gt;
&lt;tr&gt;
  &lt;td align="left"&gt;
    Athanasius&amp;emsp;&lt;font color="#008000"&gt;&amp;lt;&lt;/font&gt;[href://http://www.biblegateway.com/passage/?search=John%203:16&amp;version=NLV|&lt;font color="#008000"&gt;&amp;deg;&lt;/font&gt;]&lt;font color="#008000"&gt;(((&amp;gt;&amp;lt;&lt;/font&gt;&amp;emsp;&lt;i&gt;contra mundum&lt;/i&gt;
  &lt;/td&gt;
  &lt;td align="right"&gt;
    [href://http://translate.google.com.au/#la/en/Iustus%20alius%20egestas%20vitae%2C%20eros%20Piratica%2C|&lt;b&gt;Iustus alius egestas vitae, eros Piratica,&lt;/b&gt;]
  &lt;/td&gt;
&lt;/tr&gt;
&lt;/table&gt;
&lt;/p&gt;
&lt;/div&gt;&lt;/div&gt;</field>
<field name="root_node">
1016588</field>
<field name="parent_node">
1016953</field>
</data>
</node>
