note Chmrr <p>I'd second most of the suggestions that [Thesus] and [fruiture] offered. Furthermore, I'd comment that as this is a purely linear script, there are few advantages to using subroutines other than the visual partitioning. The downside is that it promotes either the use of globals, as you did, or rediculous amounts of variable passing. And globals, as we all know "are always bad."<sup style="font-size: 50%">{1}</sup> As such, were I writing this, I would do away with the subroutines and just deliniate the sections with comments.</p> <p>Also, you hard-code the values of the popup box -- why, when you can get at them far easier by using <code>keys %all_quotas</code>? This will also prevent errors caused by typos, as well as allowing for expansion if you add more lines of data. The same concept applies to the default value of the popup.</p> <p>Another tip is that most of the lines of <code>process_query</code> boil down to:</p> <code>sub process_query { $period = $query->param('period') || (keys %all_quotas)[0]; print_table; }</code> <p>Note the use of the || operator to set a default -- that's one of its primary uses. Lastly, the gigantic paragraph that you put in quotes looks ripe for being a HERE document.</p> <p>You can see the agglomeration of the changes [http://chmrr.net/~chmrr/test.txt|here], and the result [http://chmrr.net/~chmrr/test.pl|here]. Ignore how I removed your __DATA__ section -- I had to do so because they don't play nice with mod_perl. It is an excellent and appropriate use of __DATA__, but not one which works with mod_perl, unfortunatly.</p> <p><i>{1}</i> I hate generalizations like this. But in this case, it's usually good advice. There are times to use 'em, but here we don't need or want 'em.</p> <p>perl -pe '"I lo*`+$^X$\"$]!$/"=~m%(.*)%s;$_=$1;y^`+*^e v^#$&V"+@( NO CARRIER'</p> 214868 214868