<?xml version="1.0" encoding="windows-1252"?>
<node id="417894" title="Re: Payment changer" created="2004-12-28 19:29:21" updated="2005-04-26 14:05:36">
<type id="11">
note</type>
<author id="361852">
Forsaken</author>
<data>
<field name="doctext">
1 small comment i'd like to make is on the following part:
&lt;code&gt;
sub add {
    my $self   = shift;
    my @units  = @{ $self-&gt;{units} };
    my %pieces = %{ $self-&gt;{bills} };

    my $temp = shift;
&lt;/code&gt;
I personally use the guideline that it's best to clean out @_ and assign all the values that i need before doing anything else. 9 out of 10 times this is completely unnecessary, but consistently doing it does prevent me from leaving things in @_ only to have them changed later, yielding unpredictable results. so my advice would be to start off with 
&lt;code&gt;my ($self, $temp) = @_;&lt;/code&gt; 
and then to proceed with the remainder of the sub. </field>
<field name="root_node">
417727</field>
<field name="parent_node">
417727</field>
</data>
</node>
