<?xml version="1.0" encoding="windows-1252"?>
<node id="484252" title="Re: A refactoring trap" created="2005-08-16 17:22:49" updated="2005-08-16 13:22:49">
<type id="11">
note</type>
<author id="33341">
Albannach</author>
<data>
<field name="doctext">
One of my personal rules:  Always question a rule that starts with always.
&lt;!-- and yes that is intentional! --&gt;
&lt;p&gt;
While I agree that &lt;code&gt;/x&lt;/code&gt; can be mighty handy, I think that your case is so simple as to be made &lt;u&gt;less clear&lt;/u&gt; by the change.  Perhaps this is because I am used to certain regex idioms, or I just don't like your choice of braces, but I would have thought your first version was better, apart from the explict use of $line which is an improvement.
&lt;p&gt;
Well the best &lt;!--and worst --&gt;thing about opinions is that you can always get another.
&lt;!-- Node text goes above. Div tags should contain sig only --&gt;
&lt;div class="pmsig"&gt;&lt;div class="pmsig-33341"&gt;
&lt;p&gt;--&lt;br&gt;
I'd like to be able to assign to an luser
&lt;/div&gt;&lt;/div&gt;</field>
<field name="root_node">
484238</field>
<field name="parent_node">
484238</field>
</data>
</node>
