<?xml version="1.0" encoding="windows-1252"?>
<node id="504586" title="Re^2: Request for Comments on Perl::Critic" created="2005-11-01 08:59:03" updated="2005-11-01 03:59:03">
<type id="11">
note</type>
<author id="139958">
friedo</author>
<data>
<field name="doctext">
PBP is a great book and while I have nothing but immense respect for [TheDamian], I think he goes a little off the deep end in parts of it. When reading it, I found that about 80% of it consisted of things I already do, 15% consisted of things that might be a good idea, and 5% consisted of things that made me say, "&lt;i&gt;What the &lt;b&gt;hell&lt;/b&gt; is this nutcase thinking?!&lt;/i&gt;"
&lt;p /&gt;
But that's OK. Nobody agrees on coding standards, and in Perl especially, because there's a million ways to do everything. I like to think my code is clean, abstract, modular and well-organized, but I'm sure Damian would be horrified by some of my decisions. ("Oh no! [friedo] uses &lt;code&gt;unless&lt;/code&gt; all over the place! He must be a drooling mental patient!) You get the idea.
&lt;p /&gt;
That said, I don't think PBP is a good baseline to use for a code critic. A lot of the reccomendations are somewhat superficial, whereas a code critic should look primarily at dangerous constructs. (Non-use of &lt;code&gt;strict&lt;/code&gt;, indirect method invocation, accidental autovivification, symrefs, overly complicated conditionals, etc.)</field>
<field name="root_node">
504523</field>
<field name="parent_node">
504572</field>
</data>
</node>
