note
merlyn
I disagree about that <tt>ref($proto)</tt> part.
<p>
If you want an instance method called "new", I have no idea what it's doing.
If you want to clone an object, call your instance method "clone" or "copy".
If you want to provide a new empty object of the same class as an existing object,
just use:
<code>
my $sibling = (ref $original)->new(...);
</code>
<p>
There is <b>no</b> point in putting that ref-ish crap in something called "new".
In fact, it's misleading.
<p>
Note that I'm <b>not</b> arguing that every method should be either a class method, or an instance method, but not both. Rather, I'm saying that "new" on an instance could mean either "clone" or "make new one like...", and thus you are confusing at least half your audience, guaranteed.
<p>
Yes, there are other prominent members of the Perl community who disagree with me on this. Ask them if they were programming in Smalltalk in 1980. {grin}
<p>
I consider any use of this <tt>ref($proto) || $proto</tt> in <tt>new</tt> to be "cargo cult programming", and mark it off as such in the code reviews I do.
<p>-- <a href="http://www.stonehenge.com/merlyn/">Randal L. Schwartz, Perl hacker</a></p>
<hr><b>update:</b>
I finally wrote this up in a way that fully explains my objections. See
the last few paragraphs of [http://www.stonehenge.com/merlyn/UnixReview/col52.html|my SysAdmin column], which triggered a partial rewrite of [perltoot] for Perl 5.8.5 removing this objectionable construct.
52014
52017