<?xml version="1.0" encoding="windows-1252"?>
<node id="551158" title="Re: Consideration for others code" created="2006-05-23 09:50:13" updated="2006-05-23 05:50:13">
<type id="11">
note</type>
<author id="33341">
Albannach</author>
<data>
<field name="doctext">
&lt;i&gt;&lt;blockquote&gt;Do I point out the errors?&lt;/blockquote&gt;&lt;/i&gt;
Certainly... but have you really found some?
&lt;p&gt;
I bet that "this doesn't run under strict" won't be considered to be an error by anyone who doesn't &lt;code&gt;use strict&lt;/code&gt; in the first place.  If you have uncovered real errors somewhere (i.e. the code doesn't do what it is supposed to, or it is vulnerable to an attack, or will fail on bad data), then certainly point them out in a spirit of cooperation and teamwork.
&lt;p&gt;
If not, perhaps you would consider building some tests for the existing code instead?  This will first make you better aware of what their code is suposed to do, rather than having you working backward and trying to figure out what existing code actually does.  Once you understand the specifications, and have tests to exercise the code, then you can say with some authority whether there are true errors.  If not, I'd say leave that code alone and move to the next piece (there is always more).  It may well be that an ugly little piece of cruft is perfectly functional and even robust and need never be touched again.

&lt;!-- Node text goes above. Div tags should contain sig only --&gt;
&lt;div class="pmsig"&gt;&lt;div class="pmsig-33341"&gt;
&lt;p&gt;--&lt;br&gt;
I'd like to be able to assign to an luser
&lt;/div&gt;&lt;/div&gt;</field>
<field name="root_node">
551127</field>
<field name="parent_node">
551127</field>
</data>
</node>
