note
radiantmatrix
<p>Your <c>x!!</c> approach is nifty, but it's a little hard to read: the double-negation is confusing unless explained, and the <c>x</c> operator seems to be out of place in this context. I have always found one of these easier to read:
<code>
my $uri;
foreach (
'http://example.net/app',
$is_admin_link && 'admin',
$subsite,
$mode,
$id,
$submode,
) {
$uri.="$_/" if ( defined $_ && length($_) ) #omit undef and empties
}
</code>
<p>If you need to preserve the parts seperately:
<code>
my @part = (
'http://example.net/app',
$is_admin_link && 'admin',
$subsite,
$mode,
$id,
$submode,
);
my $uri;
foreach (@parts) {
$uri.="$_/" if ( defined $_ && length($_) ) #omit undef and empties
}
</code>
<p>I prefer these because:<ol>
<li>The logic for inclusion of parts is clear
<li>It makes it easy to apply a common rule to all components (e.g. URL-ify components before concatenation)
<li>It avoids repetition of code
</ol>
<!--
<p><small><b>Updates:</b><ul type='square'>
<li>date : desc</li>
</ul></small></p>
-->
<div class="pmsig"><div class="pmsig-375088">
<small>
<small><font color='#000000'><</font><font color='#1a1a1a'>–</font><font color='#343434'>r</font><font color='#4e4e4e'>a</font><font color='#686868'>d</font><font color='#828282'>i</font><font color='#9c9c9c'>a</font><font color='#b6b6b6'>n</font><font color='#d0d0d0'>t</font><font color='#eaeaea'>.</font><font color='#d0d0d0'>m</font><font color='#b6b6b6'>a</font><font color='#9c9c9c'>t</font><font color='#828282'>r</font><font color='#686868'>i</font><font color='#4e4e4e'>x</font><font color='#343434'>–</font><font color='#1a1a1a'>></font></small>
<!--<-</small><b>radiant</b>.<b>matrix</b><small>-></small-->
<br><a href='http://radiantmatrix.org/'>A collection of thoughts and links from the minds of geeks</a>
<br><em>The Code that can be seen is not the true Code</em>
<br><em>I haven't found a problem yet that can't be solved by a well-placed [http://en.wikipedia.org/wiki/Trebuchet|trebuchet]</em>
</small>
</div></div>
564792
564792