<?xml version="1.0" encoding="windows-1252"?>
<node id="596712" title="Re^2: Module Announcement: Perl-Critic-1.01" created="2007-01-26 09:00:54" updated="2007-01-26 04:00:54">
<type id="11">
note</type>
<author id="458049">
jthalhammer</author>
<data>
<field name="doctext">
&lt;em&gt;The magic punctuatinon it is talking about is $@ without which I could not really catch exceptions&lt;/em&gt;

&lt;code&gt;
use English qw(-no_match_vars);
eval { die 'A horrible death' };
print "Something died\n" if $EVAL_ERROR;
&lt;/code&gt;

&lt;em&gt;Useless interpolation of literal string at line ... 
&lt;br/&gt;
I don't even get that one because the line in question is basically something like this: 

&lt;code&gt;
confess 'Some error happened because ' . $obj-&gt;foo . ' blew up';
&lt;/code&gt;

I would have to say that this string was far from useless. 
&lt;/em&gt;

&lt;p&gt;
If those were double-quotes instead of single-quotes (which they probably were) then the warning was precisely correct.
&lt;/p&gt;

&lt;code&gt;
sub mumble_path { join ", " =&gt; split '/' =&gt; (shift)&gt;get_path }
&lt;/code&gt;

&lt;em&gt;
I would argue that adding return to something like that would be just adding noise. 
&lt;/em&gt;

&lt;p&gt;
You certainly can argue!  [dist://Perl-Critic-Lax] is a suite of slightly more forgiving versions of several Policies.  Perhaps you could write a new module for it.
&lt;/p&gt;

&lt;p&gt;
Perl::Critic is lenient by default.  Normally, it only reports the most severe issues (the relative severities are configurable).  However, the web-service is currently configured for maximum strictness.  I suppose I should loosen that up a bit.  One of these days, I'd like to expose all the Perl::Critic configurations through the web-service, but that's a ways off.
&lt;/p&gt;

-Jeff</field>
<field name="root_node">
596691</field>
<field name="parent_node">
596706</field>
</data>
</node>
