note strat <p>I'd use <code>or and not</code> instead of <code>|| && !</code> because the long names:</p> <ul> <li>are better readable, and especially the ! is often "hidden behind other code".</li> <li>have the lowest precedence which might avoid errors if the expressions get more complicated, especially if there are <code>.. ... ?: = += -+ and so on , =></code> within them. Especially stuff like <code>open FH, $filename || die "Error: $!";</code> is fatal.</li> </ul> <p>So I'd write it the following way, although it is a little bit longer:</p> <code> print "no editor found\n" unless defined $ENV{EDITOR} or defined $ENV{VISUAL}; </code> <!-- Node text goes above. Div tags should contain sig only --> <div class="pmsig"><div class="pmsig-123953"> <P> Best regards,<BR> perl -e "s>>*F>e=>y)\*martinF)stronat)=>print,print v8.8.8.32.11.32" </div></div> 621650 621650