<?xml version="1.0" encoding="windows-1252"?>
<node id="907076" title="Re: code critique" created="2011-05-27 18:21:15" updated="2011-05-27 18:21:15">
<type id="11">
note</type>
<author id="290905">
Old_Gray_Bear</author>
<data>
<field name="doctext">
Take a look at Damian Conway's book [ISBN://0-596-00173-8|'Perl best Practices'] and the attendant Perl module [cpan://Perl::Critic|Perl::Critic].  The Damian has some good points to make (and a few that I disagree with).  Running your code through perl-critic at a reasonable level of strictness (-4 or for the very masochistic -3) can be enlightening.  
&lt;p&gt;
Also &lt;c&gt;use warnings&lt;/c&gt; in addition to &lt;c&gt;use strict&lt;/c&gt; -- suspenders and belt....

&lt;!-- Node text goes above. Div tags should contain sig only --&gt;
&lt;div class="pmsig"&gt;&lt;div class="pmsig-290905"&gt;
&lt;p&gt;
----&lt;br&gt; 
I Go Back to Sleep, Now.
&lt;p&gt;
OGB
&lt;/div&gt;&lt;/div&gt;</field>
<field name="root_node">
907061</field>
<field name="parent_node">
907061</field>
</data>
</node>
