note philipbailey <p>Your approach is absolutely fine in a code library providing the most generalisable possible solution for escaping arbitrary shell commands. There is nothing wrong with (the factual content of) your statements. All I am saying here is that in this specific case, where we have definitive evidence (even if you do not wish to examine that evidence) that quotes are never present, that a simpler approach is sufficient.</p> 912014 912038