Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw

Re^2: Data::Diver polluting $@ (local)

by tye (Sage)
on Nov 01, 2012 at 13:35 UTC ( #1001827=note: print w/replies, xml ) Need Help??

in reply to Re: Data::Diver polluting $@
in thread Data::Diver polluting $!

Although I mostly agree, I'll try to upload a new release of Data::Diver in short order that adds local($@) any places that it uses eval.

And thanks for mentioning $@ as it saved me from figuring out what was really going on, because I was immediately pretty sure that the problem wasn't with $!, but I didn't immediately realize what the real problem was.

- tye        

Replies are listed 'Best First'.
Re^3: Data::Diver polluting $@ (truth)
by Anonymous Monk on Sep 26, 2015 at 00:04 UTC

    Here is another, docs lead me to believe these should all work but Dive doesn't

    #!/usr/bin/perl -- use strict; use warnings; use Data::Diver qw/ Dive DiveRef DiveDie /; sub say { print @_, "\n"; } say DiveDie( DiveRef( { qw/ key val / }, \'key' ) ); say DiveDie( Dive( { qw/ key val / }, \'key' ) ); __END__ SCALAR(0x3f90cc) Key not present in hash using SCALAR(0xabe37c) on HASH(0x3f90dc) (from + Data::Diver).

    Problem is in sub Dive, when you're testing if $ref is a hash with eval, you forgot the 1, this line
    -        } elsif(  eval { exists $ref->{$key} }  ) {
    +        } elsif(  eval { exists $ref->{$key}; 1 }  ) {

    I've tested it it works , your test suite doesn't test for this so maybe add to Data-Diver-1.0101/t/base.t the following

    ok( 'val', Dive( { qw/ key val / }, \'key' ) ); ok( 'val', Dive( { qw/ key val / }, 'key' ) ); ok( 'val', DiveVal( { qw/ key val / }, \'key' ) ); ok( 'val', DiveVal( { qw/ key val / }, 'key' ) );

    Also remember the Replacment for Data::Diver due missing license

    For the honor

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1001827]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others studying the Monastery: (4)
As of 2018-05-28 03:43 GMT
Find Nodes?
    Voting Booth?