Re: Putting the stringified Regexp object into code

Is there a reason you are avoiding using a closure? Doing something like

my $re = qr(/);
my $code = sub {if ($_[0] =~ $re) { blah() }};

...

$code->($data);
[download]

will probably save you some maintenance headache and keeps errors more localized to where they were coded. There is nothing wrong per se with what you've done, but it doesn't take advantage of a lot of the strengths modern Perl has to offer. In my own work, I have found that a string eval correlates strongly with me being too clever for my own good.

#11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.

Comment on Re: Putting the stringified Regexp object into code Download Code

Replies are listed 'Best First'.
Re^2: Putting the stringified Regexp object into code by sedusedan (Monk) on Nov 06, 2012 at 18:59 UTC
Yup, I am specifically generating Perl code (as string). The resulting code can be eval()-ed or embedded in other source code.	[reply]
Re^3: Putting the stringified Regexp object into code by kennethk (Abbot) on Nov 06, 2012 at 19:10 UTC
How are you embedding? This sounds like something you should be solving using modules if you need to share the result among multiple scripts. But as I said, the code should stand as is. I would point out that the `qr` in `$code = "if (\$data =~ qr/$re/) { blah() }";` is unnecessary. #11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.	[reply] [d/l] [select]
Re^4: Putting the stringified Regexp object into code by sedusedan (Monk) on Nov 06, 2012 at 19:16 UTC
Please see my reply to Anomalous. I am generating a Perl code in a string, where `$re` will become literal in the generated code. The qr// can be replaced with m//, but it's rather necessary.	[reply] [d/l]
Re^5: Putting the stringified Regexp object into code by kennethk (Abbot) on Nov 06, 2012 at 20:56 UTC
Re^6: Putting the stringified Regexp object into code by sedusedan (Monk) on Nov 07, 2012 at 00:14 UTC


Do you know where your variables are?
	PerlMonks