Re^3: File existence check failure

[Athanasius]

in reply to Re^2: File existance check failure
in thread File existance check failure

Critiques ??

As a general rule, avoid subroutine prototypes unless you have good reason for them. (See, e.g., Far More than Everything You've Ever Wanted to Know about Prototypes in Perl -- by Tom Christiansen.) With the prototype removed, and employing some Perl idioms, sub fexist can be simplified to:

sub fexist
{
    for (glob $_[0])
    {
        return 3 if -l;
        return 2 if -d;
        return 1 if -f;
    }

    return 0;
}

Improvements ??

Since the aim is to cleanup unwanted files, perhaps it would be better to integrate sub fexist with the cleanup code? Something like this:

use v5.14;
...
sub cleanup
{
    for (glob $_[0])
    {
        cleanup_link($_) when -l;
        cleanup_dir ($_) when -d;
        cleanup_file($_) when -f;
    }
}

Hope that helps,

[Festus Hagen]

Thanks,

Awakens the the spacy name beast!

Proto's ... geez my Cisims bite again. :)

-Enjoy
fh : )_~