Beefy Boxes and Bandwidth Generously Provided by pair Networks
We don't bite newbies here... much
 
PerlMonks  

Re: Fix-it fix-it fix-it!

by jwkrahn (Monsignor)
on Nov 15, 2012 at 04:52 UTC ( #1003929=note: print w/ replies, xml ) Need Help??


in reply to Fix-it fix-it fix-it!

print "What is the name of the access rights .csv? (Full file name)\n" +; my $file = <>;

That would be better written as:

print "What is the name of the access rights .csv? (Full file name)\n" +; chomp( my $file = <STDIN> );


print "Is there a header in this file?\n"; my $header = <>; if ($header =~ m/^yes|^y]/i){ $header = "1"; } else {$header = "undef"; }

At this point $header will ALWAYS be true.    I think you meant $header = undef; instead of $header = "undef";.



open (CSV, "<", $file);

You should always verify that the file opened correctly before trying to use an invalid filehandle.

open CSV, '<', $file or die "Cannot open '$file' because: $!";


Comment on Re: Fix-it fix-it fix-it!
Select or Download Code
Re^2: Fix-it fix-it fix-it!
by Tux (Monsignor) on Nov 15, 2012 at 07:08 UTC

    All good advice :)

    And of course add to this that one should use Text::CSV_XS or Text::CSV to read/parse CSV. The method in the OP might work now, but is unlikely to work when the CSV gets real.


    Enjoy, Have FUN! H.Merijn

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1003929]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others wandering the Monastery: (8)
As of 2014-09-30 14:05 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    How do you remember the number of days in each month?











    Results (372 votes), past polls