Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris

Re: Moose and File::Temp

by tobyink (Abbot)
on Nov 19, 2012 at 13:19 UTC ( #1004533=note: print w/replies, xml ) Need Help??

in reply to Moose and File::Temp

The two answers above should address the problem you're having. Here are some style tips though...

In these two lines, you are treating $self like it is a hashref...

$self->{tempfile} = File::Temp->new(UNLINK => 1, SUFFIX => '.tmp'); print $self->{tempfile} "I am here";

But self is not a hashref; it's an object. OK, so Moose implements objects as blessed hashrefs by default, but it is considered bad form to treat an object as a hashref - we're supposed to pretend that it's not a hashref, and only access the internals via the accessors that Moose gives us. So we should do this...

$self->tempfile( File::Temp->new(UNLINK => 1, SUFFIX => '.tmp') ); print {$self->tempfile} "I am here";

The reasons for doing so are not just theoretical. Accessing the object as a hashref bypasses all your type constraints, triggers, etc.

Secondly, you are initialising an attribute within the BUILD method. While you can do that, Moose does provide attribute defaults and builders for this sort of thing:

package test; # not '' use Moose; use File::Temp; has tempfile => ( is => 'rw', isa => 'File::Temp', lazy => 1, default => sub { File::Temp->new(UNLINK => 1, SUFFIX => '.tmp') }, ); sub BUILD { my $self = shift; print { $self->tempfile } "I am here"; }
perl -E'sub Monkey::do{say$_,for@_,do{($monkey=[caller(0)]->[3])=~s{::}{ }and$monkey}}"Monkey say"->Monkey::do'

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1004533]
NodeReaper listens to Dies Irae

How do I use this? | Other CB clients
Other Users?
Others musing on the Monastery: (7)
As of 2018-04-24 15:23 GMT
Find Nodes?
    Voting Booth?