Re^3: Perl::Critic and Subroutines

in reply to Re^2: Perl::Critic and Subroutines
in thread Perl::Critic and Subroutines

"I am not a fan of this policy :)"

There seems little point to it.

I actually think this is one of the best policies. As you pointed out, the performance benefits are very small. But it is immensely helpful for clarifying intent and detecting typos. Consider this code:

my $name = <STDIN>;
print "Hello, name";
[download]

Unless you had test coverage on that (or you just spotted it by eye) you'd never find that bug. But ProhibitUselessInterpolation will find it for you.

Comment on Re^3: Perl::Critic and Subroutines Download Code

In Section Seekers of Perl Wisdom