Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine

Re: ternary operator

by tmharish (Friar)
on Jan 18, 2013 at 06:55 UTC ( #1013967=note: print w/replies, xml ) Need Help??

in reply to ternary operator

Short Answer:
$a1=2; $b1=10; ($a1 > $b1) ? ($int = ($a1/$b1)) : ($int = ($b1/$a1)); +print $int;
Better Short Answer:
$a1=2; $b1=10; $int = ($a1 > $b1) ? ($a1/$b1) : ($b1/$a1); print $int;
What it should really be:
use strict ; use warnings ; # Use Better Variable Names. my $a1 = 2 ; my $b1 = 10 ; my $int = ( $a1 > $b1 ) ? ( $a1 / $b1 ) : ( $b1 / $a1 ) ; print $int;

defined($int = ($a1/$b1)) will always evaluate to true regardless of the values of $a1 and $b1. If you want to check if both $a1 and $b1 are defined you might want to nest it in there like:
my $int = ( defined( $a1 ) and defined( $b1 ) ) ? ( ( $a1 > $b1 ) ? ( +$a1 / $b1 ) : ( $b1 / $a1 ) ) : die( '$a1 and $b1 need to be defined' + ) ;
The other thing to note is that the the Ternary Operator, being an Operator, will return something and so you dont need to do the $int = in both the if and else parts.

Replies are listed 'Best First'.
Re^2: ternary operator
by frozenwithjoy (Priest) on Jan 18, 2013 at 08:55 UTC
    Besides checking whether $a1 and $b1 are defined, you'd probably also want to verify that the the smaller value is != 0. By now, we are definitely at the point where insisting on using the ternary operator causes needless issues with readability.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1013967]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others lurking in the Monastery: (7)
As of 2016-10-25 23:02 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (330 votes). Check out past polls.