Beefy Boxes and Bandwidth Generously Provided by pair Networks
more useful options
 
PerlMonks  

Re^4: Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displays

by jdporter (Canon)
on Feb 04, 2013 at 19:51 UTC ( #1017001=note: print w/ replies, xml ) Need Help??


in reply to Re^3: Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displays
in thread Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displays

In addition to the above:

Instead of long runs of single-line comments, use POD.

Instead of:

$mode=$ARGV[0]; $frames=$ARGV[1]; $lossy=$ARGV[2]; $skip=$ARGV[3]; @bitmap=`cat $ARGV[4]`;
How about:
my $mode = shift; my $frames = shift; my $lossy = shift; my $skip = shift; my @bitmap = <>;
Even better might be the use of a commandline option processor, e.g. Getopt::Long.

Instead of:

foreach $item (@bitmap) { chomp($item); $total.=$item; } @image=split(//,"$total");
How about:
chomp @bitmap; @image = split //, join '', @bitmap;

It's not clear why

$col=$c; $row=$thisRow;
Such a construct usually implies protecting variables from being clobbered... but I don't see any clobbering going on...

# If you don't want to use this optimization, just # comment out the whole if statement.
Why not provide a command line switch for it?


Comment on Re^4: Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displays
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1017001]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (7)
As of 2015-08-01 02:49 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (285 votes), past polls