Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number
 
PerlMonks  

Re^4: Output Repeats in the elsif statement

by PilotinControl (Monk)
on Feb 14, 2013 at 02:28 UTC ( #1018667=note: print w/ replies, xml ) Need Help??


in reply to Re^3: Output Repeats in the elsif statement
in thread Output Repeats in the elsif statement

changing the line to } else { did not work all it did was create this: http://65.40.136.120/~files/error.jpg which is the output I get and all i need it to say is Car Record Not Found once not multiple times


Comment on Re^4: Output Repeats in the elsif statement
Replies are listed 'Best First'.
Re^5: Output Repeats in the elsif statement
by Athanasius (Abbot) on Feb 14, 2013 at 03:12 UTC

    Hello PilotinControl,

    The output “Car Record Not Found” appears multiple times because it is within a loop. You need to change the logic to something like this (untested):

    my $found = 0; foreach my $carroadnameverify2 (@lines) { if ($carroadnameverify2 =~ /$carroadnameverify/) { printf " %-13s %-15s %-12s %0s", split(/:/, $car +roadnameverify2); $found = 1; last; } } print "CAR RECORD NOT FOUND" unless $found;

    (This assumes that each car record appears no more than once in the input file. If this is not the case, remove the last; statement from within the if clause.)

    Hope that helps,

    Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,

Re^5: Output Repeats in the elsif statement
by Kenosis (Priest) on Feb 14, 2013 at 03:13 UTC

    ...all i need it to say is Car Record Not Found once not multiple times...

    You have the following:

    ... foreach my $carroadnameverify2 (@lines) { if ( $carroadnameverify2 =~ /$carroadnameverify/ ) { my $format = " %-13s %-15s %-12s %0s"; printf( "$format", split /\:/, "$carroadnameverify2" ); } else { printf("CAR RECORD NOT FOUND"); } } # END FILE LOOP ...

    Indeed, if you have 10 non-matches within the foreach loop, "CAR RECORD NOT FOUND" will be printed 10 times. It seems, however, that you may be looking for something like the following:

    ... my $found = 0; foreach my $carroadnameverify2 (@lines) { if ( $carroadnameverify2 =~ /$carroadnameverify/ ) { my $format = " %-13s %-15s %-12s %0s"; printf( "$format", split /\:/, "$carroadnameverify2" ); $found = 1; } } # END FILE LOOP printf("CAR RECORD NOT FOUND") if !$found; ...

    This just uses $found as a flag; if it's not set (i.e., if the item wasn't found in the array), the "CAR RECORD NOT FOUND" message is printed only once.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1018667]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (13)
As of 2015-07-29 12:51 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (263 votes), past polls