Beefy Boxes and Bandwidth Generously Provided by pair Networks
Your skill will accomplish
what the force of many cannot
 
PerlMonks  

Re^3: Managing capture

by Anonymous Monk
on Feb 19, 2013 at 12:32 UTC ( #1019539=note: print w/ replies, xml ) Need Help??


in reply to Re^2: Managing capture
in thread Managing capture

To elaborate on competence, you said Note that the logging could have been added casually, and doesn't look evil on a review diff. except that it should -- when doing reviews you should be checking for cycles, esp with anonymous subs

But I don't really know what you mean by "review diff"

Also, you could write a perlcritic policy, it isn't too hard :)


Comment on Re^3: Managing capture
Re^4: Managing capture
by Anonymous Monk on Feb 19, 2013 at 12:52 UTC
Re^4: Managing capture
by jbert (Priest) on Feb 19, 2013 at 13:01 UTC

    > when doing reviews you should be checking for cycles, esp with anonymous subs

    I agree with this very much. But I think it is a hard problem. The intention of this pragma would be to make cycles caused via capture easier to spot in code review.

      I agree with this very much. But I think it is a hard problem. The intention of this pragma would be to make cycles caused via capture easier to spot in code review.

      Its not really that hard :) Devel::Cycle - Find memory cycles in objects

      It is easy to modify perlcritic ProhibitConditionalDeclarations to alert yo to closures for a code , and then you can further investigate to decide if they're really trouble, or ok

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1019539]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (12)
As of 2014-10-23 09:30 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    For retirement, I am banking on:










    Results (125 votes), past polls