Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask
 
PerlMonks  

RFC: Algorithm::Damm

by MidLifeXis (Monsignor)
on Mar 17, 2013 at 13:36 UTC ( #1023908=perlmeditation: print w/ replies, xml ) Need Help??

I have written my first module for community consumption, and am looking for comments:

I am pulling comments into git issues, so if you want to save the middleman (or provide a pull request), feel free.

--MidLifeXis

Comment on RFC: Algorithm::Damm
Replies are listed 'Best First'.
Re: RFC: Algorithm::Damm
by kcott (Abbot) on Mar 17, 2013 at 23:40 UTC

    G'day MidLifeXis,

    I haven't tested any of the functionality - just had a read through the documentation. I was pleased to see links explaining the algorithm. My only criticism would be the naming of the function is_valid(): I've seen functions with this name in many pieces of code - perhaps something less generic, to avoid naming collisions, might be a better choice.

    -- Ken

      I tried to keep the same interface as Algorithm::LUHN and others in the checkdigit generation / checking problem domain.

      If you don't want to have a collision, use the OO interface (coming Real Soon Now - see issue list), or skip the imports (use Algorithm::Damm ()) and use the fully packaged sub name. You don't even need to skip the imports, as nothing is imported (well, is not supposed to be imported) by default.

      I have to mull on this for a bit, but right now I am on the 'leave it alone' side of the fence.

      --MidLifeXis

Re: RFC: Algorithm::Damm
by choroba (Canon) on Mar 18, 2013 at 09:16 UTC
    Just a minor note: Do you think History is important enough to be placed before Functions?
    لսႽ ᥲᥒ⚪⟊Ⴙᘓᖇ Ꮅᘓᖇ⎱ Ⴙᥲ𝇋ƙᘓᖇ

      Well, uh, ya know, errr.

      Nope. Didn't quite look at POD sections that way, but that is a sensible approach (importance). Thanks.

      --MidLifeXis

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: perlmeditation [id://1023908]
Approved by Corion
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others cooling their heels in the Monastery: (14)
As of 2015-07-31 13:27 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (277 votes), past polls