Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling

Re^3: check parameters

by ag4ve (Monk)
on Apr 08, 2013 at 14:31 UTC ( #1027520=note: print w/replies, xml ) Need Help??

in reply to Re^2: check parameters
in thread check parameters

Ugh, actually something about that doesn't work.... It passes when it shouldn't :(

Replies are listed 'Best First'.
Re^4: check parameters
by Corion (Pope) on Apr 08, 2013 at 14:34 UTC

    What is wrong with the code hdb gave you?

    That code does not have the problem your code has, so why are you not using it?

    As a hint, a string is always true in Perl. And your code simply constructs a string but never matches against it:

    ... if ("(".join('|', @{$opts->{params}}).")" # This constructs a string and !grep { /^$_/i } keys %$format) # and this matches $_ agains +t itself ...

      ag4ve, can you pls state what you want to achieve? Here is what happens step-wise:

      my $pattern ="(".join('|', @{$opts->{params}}).")"; # pattern is now "(a|b)" my @test = grep { /^$pattern/i } keys %$format; # @test = ( "bar", "abc" )

      !grep... puts grep into scalar context, ie it will return 2, the length of @test above. !2 is false therefore your "if" block will not be executed.

Re^4: check parameters
by ag4ve (Monk) on Apr 08, 2013 at 14:42 UTC
    This should fail and doesn't:
    use strict; use warnings; use Pod::Usage; my $format = { abc => 1, bar => 1, fii => 1, wee => 1, }; my $opts; $opts->{params} = ["a", "fa"]; my $str = "(".join('|', @{$opts->{params}}).")"; if (!grep { /^$str/i } keys %$format) { pod2usage( -verbose => 0, -output => \*STDERR, -msg => "$0 bad parameter difinition used [" . join(", ", so +rt {$a cmp $b} @{$opts->{params}}) . "].\n" . "Possible parameters are: " . join(", ", sort {$a cmp $b} keys %$format) . "\n"); } print "1\n";

      You want it to fail if one of them fails, correct? Try this:

      if ( scalar( grep { /^$pattern/i } keys %$format ) < scalar( keys %$fo +rmat ) ) { ...

      Or this? (Observe the position of the exclamation mark.)

      if ( grep { !/^$str/i } keys %$format)

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1027520]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (7)
As of 2018-02-20 19:54 GMT
Find Nodes?
    Voting Booth?
    When it is dark outside I am happiest to see ...

    Results (274 votes). Check out past polls.