Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery
 
PerlMonks  

Re^5: Developing code to be a module (perl -lanse)

by space_monk (Chaplain)
on May 01, 2013 at 08:39 UTC ( #1031521=note: print w/ replies, xml ) Need Help??


in reply to Re^4: Developing code to be a module (perl -lanse)
in thread Developing code to be a module

Whilst the example you linked to doesn't use Test:: anything, your argument is somewhat deflated by the fact that that Text::CSV_XS has extensive unit tests attached to it, according to the Manifest you linked to. :-).

I haven't time to examine the example you referred to in detail, so I could be wrong, but I suspect there is a case to be made for contents of the main loop to be also made into a function.

Personally I'm deeply uncomfortable if someone has waffled on for 1000 lines of programming without breaking it up somehow! But I won't deny that there will always be exceptions to this principle, e.g. large tables of necessary data, text or whatever.

If you spot any bugs in my solutions, it's because I've deliberately left them in as an exercise for the reader! :-)


Comment on Re^5: Developing code to be a module (perl -lanse)
Re^6: Developing code to be a module (perl -lanse)
by Anonymous Monk on May 01, 2013 at 09:08 UTC

    Whilst the example you linked to doesn't use Test:: anything, your argument is somewhat deflated by the fact that that Text::CSV_XS has extensive unit tests attached to it, according to the Manifest you linked to. :-).

    Sure its not :) None of those unit-tests cover/check csv2xls, a human does that

    I haven't time to examine the example you referred to in detail, so I could be wrong, but I suspect there is a case to be made for contents of the main loop to be also made into a function.

    Sure there is, if you want to make it into a module, like the OP describes.

    But as a stand alone program, its perfectly serviceable without being a function -- and has been since Text-CSV_XS-0.26 in 2007

    Personally I'm deeply uncomfortable if someone has waffled on for 1000 lines of programming without breaking it up somehow!

    I learned about it from those pythong folks, they call it whitespace, I hear it can work for anyone :)

    :D

      The item of code you have quoted is what is known as an example; if it were used in a professional environment you would write a unit test for it. Unit tests have a purpose; if someone comes along to improve the code, then they can verify that their changes do not screw it up in any way.

      If you spot any bugs in my solutions, it's because I've deliberately left them in as an exercise for the reader! :-)

        The item of code you have quoted is what is known as an example;

        Sure its not; yeah, its in the example directory, but it does a real job , and does it well, and comes with documentation; it is a real useful program

        if it were used in a professional environment you would write a unit test for it...

        Maybe it is being used in "a real professional environment"? Maybe different environments have different standards? Maybe, there is a threshold, for when to turn stuff into modules, when to write unit tests?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1031521]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (5)
As of 2014-12-21 00:11 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    Is guessing a good strategy for surviving in the IT business?





    Results (100 votes), past polls