Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw

script review

by georgecarlin (Acolyte)
on Sep 19, 2013 at 10:33 UTC ( #1054830=monkdiscuss: print w/replies, xml ) Need Help??

Hi all, is there a section here where I could post a script and have interested/bored people help me improve it? It's working as intended but I would like to escape the "self-taught-nastyness" and improve my overall understanding and scripting style. It is lengthy (alltogether ~1k relevant lines) which is why I didn't post it right away. Apologies if this is the entirely wrong place for something like that.

Replies are listed 'Best First'.
Re: script review
by CountZero (Bishop) on Sep 19, 2013 at 11:58 UTC
    And don't forget to add some comments about the purpose of the script, in which environment it will run, any external constraints that apply to it, why you made some design choices, ...

    1K lines is long for a script, so perhaps you can split it up into separate logical sections. That will certainly improve your chances the Monks will have a look.


    A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James

    My blog: Imperial Deltronics
Re: script review
by eyepopslikeamosquito (Chancellor) on Sep 19, 2013 at 21:14 UTC

    A number of attempts have been made to address this problem over the years; for example, Simon Cozens once set up a (now defunct) "code review ladder". At that time, there were more folks wanting reviews than prepared to do them, presumably because performing a detailed, quality code review is very time consuming and few people have the time and inclination to do it.

    You might try posting some of your code to the latest attempt at such a site, namely PrePAN. However, before doing that, I suggest you isolate small pieces of code that you're unhappy with and post multiple small questions here to the Seekers of Perl Wisdom section. That way, you will surely get a quick response which you can use to improve and polish your code before submitting to PrePAN, say (if PrePAN is appropriate for your code, which we would be able to advise on).

Re: script review
by Laurent_R (Canon) on Sep 19, 2013 at 11:07 UTC

    I don't know if many people will want to go through such a long piece of code, but the very least you should do is to include the code within <readmore>...</readmore> tags.

Re: script review
by daxim (Chaplain) on Sep 19, 2013 at 10:39 UTC

      →→→ Meditations is over there →→→

      For what purpose?

      I see Considered: Old_Gray_Bear: Please move to Meditations but meditations is not the place to ask where to post on perlmonks, monkdiscuss (this section) is that place to ask how perlmonks works

      Or if you're suggesting meditations as a place to post for code for perlmonks to review, its not, its SOPW, see Where should I post X?

      thank you very much.
Re: script review
by talexb (Canon) on Sep 20, 2013 at 12:43 UTC

    This is a meta-comment: I believe this post is in the correct section, the discussion section, as it asks to which section a post should be made.

    Alex / talexb / Toronto

    Thanks PJ. We owe you so much. Groklaw -- RIP -- 2003 to 2013.

Re: script review
by Anonymous Monk on Sep 20, 2013 at 14:01 UTC
    Pragmatically speaking, you need to carve out a small excerpt of your code that represents either a very-focused problem or a very-focused question or RFC, because when most of us do peer-reviews we are being paid for it (and, as such, we're usually quite busy nearly all of the time). Therefore, you need to plan your "pitch" in-advance very carefully so that it can be meaningfully answered and meaningfully-answered quickly. If you do that, you will get your meaningful answer very quickly indeed. (PM is famous for that.)

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: monkdiscuss [id://1054830]
Approved by toolic
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others musing on the Monastery: (3)
As of 2018-05-27 18:45 GMT
Find Nodes?
    Voting Booth?