Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling
 
PerlMonks  

Re: RFC: beginner level script improvement

by jwkrahn (Monsignor)
on Sep 23, 2013 at 01:54 UTC ( #1055222=note: print w/ replies, xml ) Need Help??


in reply to RFC: beginner level script improvement

You seem to be confused about references:

$RESULT = &getdata(\%DATA,\%CONFIG,\%STATIC); ##read config-file ... if ($PROTO =~ m/ssh/i){ %DATA = &connect2cpe_SSH(\%DATA,\%CONFIG,\%STATIC); }else{ %DATA = &connect2cpe_TELNET(\%DATA,\%CONFIG,\%STATIC); }

You are calling those functions with references to three hashes but only in getdata() do you actually dereference those hashes:

$STATIC->{$T[0]}=$T[1]; ... $DATA{$IP}->{COMMANDS} = \@COMMANDS; $DATA{$IP}->{MATCHES} = \@MATCHES;

Otherwise you are just modifying the file scoped hashes.

And then for connect2cpe_SSH() and connect2cpe_TELNET() you copy the already modified %DATA back to itself?    Whether you modify %DATA directly or through a reference there is no need to copy it to itself.



if ($#ARGV < 0 ) { &help($0); exit 0;} ... 'help|h' => sub { &help($0); exit 0;} ) || die(&help($0));

help() returns a value but you never use that value so why return it?    You pass the $0 variable to help() but because you import help() into the current program the $0 variable is directly available inside help().    Every time you use help() you exit the program.    Perhaps you should put an exit at the end of the help() subroutine and maybe call it "print_help_and_exit"?


Comment on Re: RFC: beginner level script improvement
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1055222]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (7)
As of 2014-09-19 09:20 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    How do you remember the number of days in each month?











    Results (133 votes), past polls