Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical

Re^5: efficient determination of in/out of hours

by soonix (Monsignor)
on Oct 18, 2013 at 10:31 UTC ( #1058739=note: print w/replies, xml ) Need Help??

in reply to Re^4: efficient determination of in/out of hours
in thread efficient determination of in/out of hours including Bank Holidays

You either need a mktime that is time zone aware (POSIX::mktime seems to know about DST but not about time zones), or an UTC variant, e.g. Time::timegm. Of course, the logic of $today instead of time needs to be applied, anyway. (I tried it out, seems to work)

In the tests, the first date (from the future) kills too many holidays :-) (you should either sort the test data before the test, or create a new ooh() when time traveling)

Update: The easiest fix would have been (in the originally posted version):

my $today = POSIX::mktime(0,0,0,(localtime)[3..5]); while (<DATA>) { # read bank holiday file ...

Replies are listed 'Best First'.
Re^6: efficient determination of in/out of hours
by Random_Walk (Prior) on Oct 18, 2013 at 13:09 UTC

    Even after working out $today in epoch, I still had the problem that I was storing bank hols as epoch. I would also need to look at each bank hol, and apply correct daylight saving time, before I could correctly establish its epoch start. I realised it was much easier to store bank hols as yyy:MM:DD and look at the date from localtime when I flip.

    I found another edge case around the transitions between saving/non saving. This could be bad as I may be treating alerts as OOH for an hour when the clocks go forward. I have added the following code to the main node to fix this

    $valid = POSIX::mktime(@start, $date, $mnth, $yr); $valid += $add * (24*60*60); # Check for daylight savings adjustment my $dst = $start[2] - +(localtime $valid)[2]; $valid += $dst * 60 * 60; my $now = time;


    Pereant, qui ante nos nostra dixerunt!

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1058739]
[atcroft]: Discipulus: I looked back at your note about my Padre question from a while back, and it made me look again... as a result, I found what I was missing and was able to make the change. Thank you!

How do I use this? | Other CB clients
Other Users?
Others drinking their drinks and smoking their pipes about the Monastery: (7)
As of 2018-02-24 20:35 GMT
Find Nodes?
    Voting Booth?
    When it is dark outside I am happiest to see ...

    Results (311 votes). Check out past polls.