Re: Printing a String (TOO stupid?)

[AnomalousMonk]

Possibly the chomp-ed  $line still has a carriage-return at the end of it.

c:\@Work\Perl\monks>perl -wMstrict -le
"my $line = qq{01234567\x0d};
 print qq{It was $line!!!\n};
"
!!!was 01234567

This might arise if, e.g., the file had been created on a Windows system (with  \x0d\x0a line-enders) and then transferred to a *nix system without proper newline translation. On the *nix system, chomp will take care of the  \x0a but leave the  \x0d untouched.

(BTW: It may or may not be too stupid, but the reason I know about this sort of thing is that I've done it myself — and more than once!)

[jimson]

Seems exactly so. I tested using 'chop' twice, which finally work.

However, this would make the code only work for Windows. Any suggestion on how to let such codes portable to Unix?

[AnomalousMonk]

Probably the best approach would be to do a proper system-to-system transfer in the first place. (Update: On second thought, see below for probable BP.) E.g., the ftp utility common to most (all?) OSen has an ascii mode (automatic line-end translation) as well as a binary (don't touch nuthin') mode.

Otherwise, doing something like
    $line =~ s{ [\x0d\x0a]+ \z }{}xms;
to each and every line would do the trick to eliminate any possible combination of  \x0d and  \x0a characters from the end of the line. Other regexes can handle more particular combinations of line-enders.

[Corion]

Ugh. I prefer transfers to remain as dumb as possible, as usually somebody switches to compressed files instead of text files somewhere down the road. Also, finding out whether two data deliveries are the same becomes really hard if their checksums and filesizes don't match at either end.

So I'm firmly in the latter camp of doing the conversion in Perl instead of doing the conversion at transfer time.

[Anonymous Monk]

trim :) How do I remove whitespace at the beginning or end of my string? s/\s+$//;

[RonW]

Updated

I was wrong. Somehow, I remembered it working differently.

But { local $/ = ''; chomp($x); } seems to work. Needs more testing and I'm not sure there would still be a performance benefit.

---

Try chomp; chomp; instead of chop; chop;

chomp is conditional. Being built in, I would expect it to be more efficient than a regex.

[Laurent_R]

That's wrong in this specific case. Here, you have a Windows file with "\r\n" line ends. Under Unix, the chomp command will remove only the "\n" part, but not the "\r". Using chomp a second time will not remove the "\r" under Unix. So the printing goes back to line start and the three !!! overwrite the beginning of the line.

The best solution here is to remove the "\r":

chomp $line;
$line =~ s/\r//g;

or

$line =~ s/[\r\n]//g;