Re^3: inconistent test results when using is_deeply to test an array returned from a function

[APGRMF]

Having read/investigated a bit more, I think my original question/title was misleading - I think the issue comes down to: how do I compare two arrays for equality. Note: the equality test needs to sort the arrays first or ignore array order

[Anonymous Monk]

I think the issue comes down to: how do I compare two arrays for equality. Note: the equality test needs to sort the arrays first or ignore array order

is_deeply is the best way to compare two data structures for equality. If the order of an array doesn't matter in the test, then it's fine to sort first: is_deeply([sort @got_files], [sort @expected_files]); (or you can sort the arrays earlier if you like). The other way to hold unsorted data would be with a hash (the difference being that an array allows duplicate values while a hash does not allow duplicate keys, and that an array will keep the order of its values while a hash will not), however is_deeply can also easily compare two hashes. So e.g. my %files = map { $_ => 1 } @files; is_deeply \%files, \%expect_files;

[APGRMF]

Brilliant - thank you.

I was investigating along those lines but my syntax to sort the arrays wasn't up to it, not quite sure I understand why just yet:

is_deeply(sort(\@got_files), sort(\@expected_files), 'Function should return a list of directory contents that will be processed');

However, your suggested syntax does the job:

is_deeply([sort @got_files], [sort @expected_files], 'Function should return a list of directory contents that will be processed');

[kennethk]

When you say sort(\@got_files), sort sees a one-element list that contains an array reference. Since you want to sort the array, you have to pass sort the list, not a reference that contains it. HTH.