Number guessing game

[Anonymous Monk]

I have everything working except I can not figure out a way to get it to say all of the previous guesses I can only get the last one. I've looked in all of the resource material I have and am missing it. Any help is appreciated

#!/usr/bin/perl
use Modern::Perl;


my $target = (int rand 100) + 1;
my $number = 99 ;

GUESS: foreach my $guess_num (1..$number) {
      say "($guess_num) Please enter a guess:";
      my $guess = <>;
      chomp $guess;


      unless ($guess =~ /^\d+$/) {
      say "This guess is out of range. Guess between 1 and 100!";
      redo GUESS;
      }

      if ($guess == $target) {
      say "Congrats, you guessed right!";
      last GUESS;
      }

      elsif ($guess < $target) {
      say "Your guess of $guess was too small.";
      say "your previous guesses:$guess,";
      }

      elsif ($guess > $target) {
      say "Your guess of $guess was too big.";
      }

      if ($guess_num == $number) {
      say "You have used all your guesses. Please try again.";
      last GUESS;
      }
      }

[Athanasius]

To keep a record of all the (valid) guesses made, use an array:

my @guesses;

GUESS: ...

Then, once a guess has been validated, push it onto the array:

push @guesses, $guess;

When you want to print all the guesses made so far, you can say:

print join(', ', sort { $a <=> $b } @guesses), "\n";

Hope that helps,

[Anonymous Monk]

push is too suspicious, I'd say the OP is supposed to do something like $numbers[ $guess_num - 1 ] = $guess

[toolic]

Here is an enhancement: you can use a hash to show all guesses and to notify the user that a guess was already used. I also fixed your range check to match your printed advice (1 to 100). Finally, I used perltidy.

use Modern::Perl;

my $target = ( int rand 100 ) + 1;
my $number = 99;

my %guesses;
GUESS: foreach my $guess_num ( 1 .. $number ) {
    say "($guess_num) Please enter a guess:";
    my $guess = <>;
    chomp $guess;

    if ( ($guess =~ /\D/) or ($guess > 100) or ($guess == 0) ) {
        say "This guess is out of range. Guess between 1 and 100!";
        redo GUESS;
    }

    if ( $guess == $target ) {
        say "Congrats, you guessed right!";
        last GUESS;
    }

    elsif ( exists $guesses{$guess} ) {
        say "You already guessed $guess.";
    }

    elsif ( $guess < $target ) {
        say "Your guess of $guess was too small.";
    }

    elsif ( $guess > $target ) {
        say "Your guess of $guess was too big.";
    }

    $guesses{$guess}++;

    print "your previous guesses: ", join ' ', sort {$a <=> $b} keys %
+guesses;
    print "\n";

    if ( $guess_num == $number ) {
        say "You have used all your guesses. Please try again.";
        last GUESS;
    }
}