Re: Creating a new file in a directory

Suggestion:

instead of creating the filename twice, like in

open my $OUT, '>>', "$mycrdir/file_detail.txt" or die "Can't create '$
+mycrdir/file_detail.txt'" ;
[download]

it is better do it once and use a variable

my $filename = "$mycrdir/file_detail.txt";
open my $OUT, '>>', $filename
  or die "Can't create '$filename'";
[download]

The reason is to avoid any chance of updating the filename used for open() but forgetting about the error message.

one more improvement - include the reason why the open failed

open my $OUT, '>>', $filename
  or die "Can't create '$filename': $!";
[download]

P.S.: You are using UNIX-Style forward slashes on a Windows-Platform: D:\.../file_detail.txt You probably want to fix that.

Comment on Re: Creating a new file in a directory Select or Download Code

Replies are listed 'Best First'.
Re^2: Creating a new file in a directory by RonW (Parson) on Aug 21, 2015 at 19:01 UTC
P.S.: You are using UNIX-Style forward slashes on a Windows-Platform: D:\.../file_detail.txt You probably want to fix that. The Windows "kernel" accepts forward slashes as well as back slashes as directory delimiters. The forward slash is usually only a problem with command line applications (and cmd.exe) which expect options to be introduced by forward slash. However, Unix, Linux and related OSs do not accept back slash as directory delimiters. Also, there are other OSs use other characters and do not accept either back or forward slashes as directory delimiters.	[reply]
Re^3: Creating a new file in a directory by Monk::Thomas (Friar) on Aug 24, 2015 at 08:15 UTC
This (and Anonymous') is a typical technical answer. Totally correct but both of you fail to consider the actual user. The filename is presented to the user as part of an error message. Wouldn't it be a lot more user friendly if the program shows the filename in native format? That way the user doesn't have to concern itself with what's going on behind the scenes. Also, there are other OSs use other characters and do not accept either back or forward slashes as directory delimiters. I am totally aware of that and I am quite fond to let Path::Class handle that for me. However it's a bit besides the point. The OP did not imply that the program was running on any other OS besides Windows.	[reply]
Re^2: Creating a new file in a directory by Anonymous Monk on Aug 21, 2015 at 09:19 UTC
Monk::Thomas : P.S.: You are using UNIX-Style forward slashes on a Windows-Platform: D:\.../file_detail.txt You probably want to fix that. Perfectly normal win32 feature	[reply]


Keep It Simple, Stupid
	PerlMonks