Problems? Is your data what you think it is? | |
PerlMonks |
Re: Perl script to check database works or does it?by chacham (Prior) |
on Jan 05, 2016 at 15:04 UTC ( [id://1151965]=note: print w/replies, xml ) | Need Help?? |
Side comments on the SQL itself. Dynamic SQL is not a good idea. The script uses EXECUTE IMMEDIATE, whose documentation warns of SQL Injection right on top. Though, dealing with owner names like this limits the alternatives. Anyway, there are other statements here that can clearly use placeholders. SELECT * should not really be used outside of EXISTS() and ad hoc queries. Listing the column names directly is self-documenting, and protects against column changes or reordering. A sub-query inside the ORDER BY clause is probably not the most efficient method. Are you sure that is the best way to do it? Personally, when i wanted to report on a few instances of Oracle, i installed XE locally and created DB Links to each. Then, reporting on them was both safe and easy.
In Section
Seekers of Perl Wisdom
|
|