Re: Bug in X11::Protocol::Socket?

croak "end of file" unless $n;Does that sound reasonable?

Reasonable, if a little unfriendly.

I wonder whether you might change it so that that at end of file, it returns whatever it got:

sub get {
    my($self) = shift;
    my($len) = @_;
    my($x, $n, $o) = ("", 0, 0);
    my($sock) = $$self;
    do {
        $n = $sock->sysread($x, $len - $o, $o);
        croak $! unless defined $n;
        $o += $n;
    } until $o == $len or $n == 0;

    return $x;
}
[download]

But maybe there is no circumstance in which getting less than is expected (how does it know how much to expect?) is a recoverable error?

With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'

Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.

"Science is about questioning the status quo. Questioning authority". I knew I was on the right track :)

In the absence of evidence, opinion is indistinguishable from prejudice. Not understood.

Comment on Re: Bug in X11::Protocol::Socket? Select or Download Code


Keep It Simple, Stupid
	PerlMonks