Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Re: passing a variable from one subroutine to another

by jeroenes (Priest)
on Oct 05, 2001 at 14:38 UTC ( #116956=note: print w/ replies, xml ) Need Help??


in reply to passing a variable from one subroutine to another

You are asking about general advice, so that's what you'll get ;-).

What you have done (implicitly) is creating a global variable. That's a Bad Thing (tm).

Why? Because your subs become dependent on each other. On its turn that means that your code becomes harder to debug/ maintain, harder to reuse ("Where the hack does that $error come from?") and easier to break, among others.

So, pass the variable to your sub. Or pass an object or hash that contains the info or has the right methods. Everything is better than a global.

Try to read 'Code Complete' by McConnell to get it explained better than I could....

Jeroen
"We are not alone"(FZ)

PS: ++ for the use of strict, and for your approach to break the sub into components. Maybe try to think of the different functionalities. Like: Is error reporting a subfunction of logging, or something separate, or at another level, or something that the average user should be protected from (yes!)?


Comment on Re: passing a variable from one subroutine to another

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://116956]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (13)
As of 2014-07-28 15:30 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My favorite superfluous repetitious redundant duplicative phrase is:









    Results (202 votes), past polls