How to add a new column into my csv file?

[chaney123]

Hi all,

After I succeeded in combining the two files into one using hash, I have a problem now to add one more column into the last column. So I have these two files:

File1:

Item,Period,Waveform,Attributes,Sources
an_en11,200.00,{0 133},{ }
br_gh13,140.09,{0 59},{ }
ce_oy74,300.05,{0 230},{int_43}
dt_pp50,200.11,{0 122},{ }
er_tk02,305.47,{0 220},{ }
ef_yb41,200.05,{0 233},{ }

File2:

Item,Sink,Buffer,Cell,Slew,Path,Violation,Area 
dt_pp50,0,0,2,0.000,0.000,0,0.000
er_tk02,0,2,3,0.002,0.004,0,0.001
ef_yb41,0,1,5,0.000,0.000,0,0.000

I wish to generate the last column (%Skew) by using (Slew/Period)*100%.

Item,Sink,Buffer,Cell,Slew,Path,Violation,Area,Period,%Skew
dt_pp50,0,0,2,0.000,0.000,0,0.000,200.11,(Slew/Period)x100%
er_tk02,0,2,3,0.002,0.004,0,0.001,305.47,(Slew/Period)x100%
ef_yb41,0,1,5,0.000,0.000,0,0.000,200.05,(Slew/Period)x100%

Is there any suggestion on what command should i use in my script to get the output? My code :

#! /usr/intel/bin/perl-w
use strict;
use warnings;

my %file1Hash;
my $value1;
    
open my $file1, "<","design.rpt.csv"; 
open my $file2, "<","summary.rpt.csv"; 
open my $outfile_1, ">", "combined.rpt.csv";

print $output_1 "Item, Sink, Bufer, Cells, Slew, Path, Violation, Area
+, Period, %Skew\n";
while(my $line = <$file1>){
        
    chomp $line; 
    my($key, $value1) = (split /,/, $line);
    if (defined $key) {
        $file1Hash{$key}= $value1;    
                
            }
    else {
        # print $line."\n";
            }     
    } 
        
while(my $line1 = <$file2>){ 
        
    chomp $line1; 
    my($key1) = (split /,/, $line1) ; 
        
    if (defined $file1Hash{$key1}) {
        print $outfile_1 $line1.",".$file1Hash{$key1}."\n";           
+ 
            } 
    else {
#         print $line1."\n";
            } 
} 

close $file1;
close $file2;
close $outfile_1;

Where should i start or how do i start?

[Tux]

Stop using split, install Text::CSV and/or Text::CSV_XS and read their docs.

[chaney123]

Hi,

Thanks for the suggestion but may I know what's the reason behind it? Is split not efficient? Sorry, I just started to learn Perl few weeks ago.

[hippo]

what's the reason behind it?

The modules will handle any complications: embedded separation characters, quoting rules, missing columns, character encoding, EOL issues, etc. split will simply split a string into a list which is fine for trivial, well-formed in-memory CSV datasets. To go beyond such datasets would be tortuous without using Text::CSV_XS et al.

It is the same reason why you would not be recommended to use regular expressions to parse any but the most trivial XML sets, for example.

Update: (edited for typo)

[kcott]

G'day chaney123,

See the response I gave you two days ago.

Change

$csv->print(\*STDOUT, [$_, @{$data{$_}}]) ...

to

$csv->print(\*STDOUT, [$_, @{$data{$_}}, SKEW]) ...

where SKEW evaluates to your new column datum.

[Laurent_R]

Hi chaney123,

in which respect does your script not fulfill your needs?

I can see one coding error in this line:

print $output_1 "Item, Sink, Bufer, Cells, Slew, Path, Violation, Area
+, Period, %Skew\n";

The $output_1 variable has not been defined (you presumably mean $outfile_1), but I assume that this is just a mistake while copying the code into your post, since this would generate a compile time error fairly easy to understand and to fix.

Besides that, the general algorithm seems correct to me for what you want to do. So, please tell us how your script fails to do what you want.

[chaney123]

Yea you are right! I copy my codes wrongly. It should be $outfile_1. My problem is that I have no idea on how to perform calculation from the csv files generated. I wish to generate a %skew by using the data in column 'skew' and 'period' *Formula: ('skew' / 'period')100.* Can you give me some idea on how to continue? Thanks

[poj]

while (my $line1 = <$file2>){ 
        
  chomp $line1; 
  
  # Item,Sink,Buffer,Cell,Slew,Path,Violation,Area
  my @f = split /,/, $line1 ; 
  my $item = $f[0];
  my $slew = $f[4];
  next if $item eq 'Item'; # skip header
        
  if (defined $file1Hash{$item}) {
    my $period = $file1Hash{$item};
    my $pc = sprintf "%.10f",100*$slew/$period unless ($period==0);
    print $outfile_1 join ',',$line1,$period,$pc."\n";        
  } 
}

poj

[Laurent_R]

Just a quick piece of code that seems to be doing what you want:

use strict;
use warnings;
use Data::Dumper;

my $file1 = "an_en11,200.00,{0 133},{ }
br_gh13,140.09,{0 59},{ }
ce_oy74,300.05,{0 230},{int_43}
dt_pp50,200.11,{0 122},{ }
er_tk02,305.47,{0 220},{ }
ef_yb41,200.05,{0 233},{ }";

open my $FH1, "<", \$file1 or die "cannot open $file1";
my %file1Hash;
while (my $line = <$FH1>) {
    my ($item, $period) = split /,/, $line;
    $file1Hash{$item} = $period;
}
close $FH1;
print Dumper \%file1Hash;

my $file2 = "dt_pp50,0,0,2,0.000,0.000,0,0.000
er_tk02,0,2,3,0.002,0.004,0,0.001
ef_yb41,0,1,5,0.000,0.000,0,0.000";

open my $FH2, "<", \$file2 or die "cannot open $file2";
while (my $line = <$FH2>) {
    chomp $line;
    my ($item, $slew) = (split /,/, $line)[0,4];
    next unless $file1Hash{$item}; # skip the line if the period is no
+t defined or if it is 0
    my $skew = 100 * $slew / $file1Hash{$item};
    printf "%s,%d,%.8f\n", $line, $file1Hash{$item}, $skew;
}

Note that I embedded the input data into the code for simplicity of the test.

And an sample execution (at the command line):

Read more... (2 kB)
Also note that I used split to keep closer to your code, but it would make sense to use Text::CSV_XS or Text::CSV as recommended earlier by other monks, especially if your input data gets more complicated.

HTH.