Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?
 
PerlMonks  

Missing "Vote" button

by syphilis (Chancellor)
on Oct 01, 2017 at 03:23 UTC ( #1200442=monkdiscuss: print w/replies, xml ) Need Help??

Hi,
The "++" and "--" selections for the individual posts are enabled, but there's no "Vote" button that I can see at csv2png.pl - Line Graphs from a CSV file.
Who took it ?

In other threads that I've just checked, the "Vote" button is in the usual place.

Cheers,
Rob

2017-10-01 Athanasius made link relative

Replies are listed 'Best First'.
Re: Missing "Vote" button
by Athanasius (Chancellor) on Oct 01, 2017 at 06:57 UTC
Re: Missing "Vote" button
by kcott (Chancellor) on Oct 01, 2017 at 21:50 UTC

    G'day Rob,

    I investigated this a little. Firstly, I can confirm what you're seeing.

    Opening replies to that node shows the radiobuttons (++/--/+=0) and a [vote!] submit button. These all seem to work as normal.

    I looked at #59098. This is a single reply with no child nodes. I voted (++) on it: now showing "Reputation: 7".

    I also looked at #153429. This reply starts a subthread; it has multiple branches; one branch goes to "Re^5". I voted (++) on this reply, as well as the Re^5 node: all worked as usual and "Reputation: ..." now replaces the radiobuttons.

    I refreshed the parent node (csv2png.pl - Line Graphs from a CSV file) after each operation: "Reputation: ..." was shown as appropriate; a [vote!] button remained absent.

    All Reputations were greater than one, so I'm not the first to vote on these; however, I have no idea of the "who", "when" or "how" of these other votes.

    It would appear that, at this point at least, you can vote on any of the nodes (except the parent), albeit with some minimal hoop jumping.

    — Ken

Re: Missing "Vote" button
by Athanasius (Chancellor) on Nov 18, 2017 at 07:43 UTC
      That's not entirely correct, you can vote on the replies if you open them individually, like Re: Modern Perl 4th Edition .

      I looked into the code yesterday, and review display page lacks inclusion of votehead and votefoot to include the form and submit button.

      There are recent patches mentioning voteit from jdporter, but I have trouble grasping them.

      I could create new patches, but I'd like to first discuss them with jdporter, who is absent at the moment.

      Understanding the monastery mechanics is not straight forward. ..

      Cheers Rolf
      (addicted to the Perl Programming Language and ☆☆☆☆ :)
      Je suis Charlie!

      update

      Added deeplinks into the code which are only accessible for some cabal

        That's not entirely correct, you can vote on the replies if you open them individually.

        I think Athanasius may have meant exactly that: you can vote on the replies only, but not on the thread's first node Modern Perl 4th Edition/1203697 itself.

        At least that is what I have understood.

        Cheers, Sören

        Créateur des bugs mobiles - let loose once, run everywhere.
        (hooked on the Perl Programming language)

        > I looked into the code yesterday, and review display page lacks inclusion of votehead and votefoot to include the form and submit button.

        I submitted a patch which should fix it for reviews , let's see what happens after the gods applied it.

        I can only guess that jdporter planned some refactoring in March 2016, but I wasn't able to locate the "voteformcontainer" he's mentioning.

        Cheers Rolf
        (addicted to the Perl Programming Language and ☆☆☆☆ :)
        Je suis Charlie!

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: monkdiscuss [id://1200442]
Approved by Athanasius
Front-paged by kcott
help
Chatterbox?
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (4)
As of 2018-01-19 00:38 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    How did you see in the new year?










    Results (215 votes). Check out past polls.

    Notices?