Beefy Boxes and Bandwidth Generously Provided by pair Networks
Come for the quick hacks, stay for the epiphanies.
 
PerlMonks  

Re: berrybrew, the perlbrew for Windows, updated to v1.18

by Jenda (Abbot)
on Feb 17, 2018 at 01:58 UTC ( [id://1209368]=note: print w/replies, xml ) Need Help??


in reply to berrybrew, the perlbrew for Windows, updated to v1.18

So I looked at the C# code and I have a few comments.

 .Select(x => x.Split(new char[] {'.'})) is better written as  .Select(x => x.Split('.')). No need to explicitly construct the array unless you have to pass the count or split options.

There's no point in splitting the version and then joining it back. Just keep it. Same way as if you used the Schwartzian transform in Perl. The code has to be somewhat more talkative, in part because the IEnumerable (aka list) transformations (.Select() aka map{}, .Where() aka grep{} and so forth) are kinda lazy and sometimes you have to make sure they are applied and the result remembered. And you have to choose the data structure used to remember them.

This is how I would write the code:

var sortedPerlVersions = perlVersions .Select(x => new { full = x, parts = x.Split('.').Select(n => Conv +ert.ToInt32(n)).ToArray() }) .OrderBy(x => x.parts[0]).ThenBy(x => x.parts[1]).ThenBy(x => x.pa +rts[2]) .Select(x => x.full) .ToList();

You do not have to specify all those types. List<int> nameLengths = new List<int>(); is equivalent to var nameLengths = new List<int>(); and it's shorter and easier to modify.

Same with things like foreach (string perlName in Perls.Keys)

Jenda
Enoch was right!
Enjoy the last years of Rome.

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://1209368]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others goofing around in the Monastery: (5)
As of 2024-04-24 12:28 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found