|Think about Loose Coupling|
Re: logrotateby CharlesClarkson (Curate)
|on Nov 12, 2001 at 20:54 UTC||Need Help??|
You don't need $confignr. Changing the for a bit will load $_ with each array element. (Note: for and foreach are the same.)
the next unless /^(\b)\s+(\b)\s+(\b)/; line adds some error checking.
BTW, does that regex work?
The subroutine could be indented to highlight it better
might look like:
You really should check the open for success. I'm uncertain why $appid is defined with our. Can you explain? Try testing $appid before killing it.
There should be no need to undef $log; as $log is lexically scoped to the foreach block.instead of:
Charles K. Clarkson
The vast majority of the Earth is underground. - R. Zubrin