Beefy Boxes and Bandwidth Generously Provided by pair Networks
Clear questions and runnable code
get the best and fastest answer
 
PerlMonks  

Re: Code review on script site

by demerphq (Chancellor)
on Nov 24, 2001 at 20:59 UTC ( #127272=note: print w/replies, xml ) Need Help??


in reply to Code review on script site

Regarding the style issue, I think you need to be careful. As has been pointed out in the subthread starting at Re: Re: Code review style is matter of opinion, often passionate, but at the same time has important side effects. Nevertheless the existance of a powerful formating tool such as perltidy makes some of these points redundant.

Personally I would would come up with a standard configuration for perltidy and then run all scripts through it prior to evaluation, and also publishing. This ensures that all scripts are of a uniform indentation and formatting style. Which leaves stylistic evaluation the more import issues such as as the use of obfu'd constructs, map in void context, stringification habits, commenting habbits, variable naming but exclude the more trivial (on the low level of correctness that is) and personal issues such as brace positioning and indentation size.

Yves / DeMerphq
--
Have you registered your Name Space?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://127272]
help
Chatterbox?
[erix]: makes me think of MMM too (mythical man month): "adding more people to a project makes it slower"
[erix]: that should be "to an already-too-late- project" I think
[ambrus]: oh yes, we have a pretty good example of that when they reorganized the grill place in the restaurant nearby.
[ambrus]: it now has two more people working there, and they're serving slower and more expensive.
[ambrus]: It used to be just a master cook who takes the order and puts the meat and eggs on the open grill plate table, and an assistant who removes them to a plate, adds the side dish, and gives the plate to the people in the queue, plus a cashier.
[ambrus]: Now it has five people instead of three, some sort of call number ticket system where people wait a lot for their food to get ready (it's the same kinds of grilled meat and fish on the same equipment, it won't actually fry slower),
[ambrus]: it's slow as hell, and the food costs significantly more.
[ambrus]: We no longer eat there.
LanX Everybody quotes it, some people read it, and a few people go by it
[ambrus]: LanX: why would I read it? isn't it a book for managers? I don't want to be a manager.

How do I use this? | Other CB clients
Other Users?
Others lurking in the Monastery: (13)
As of 2017-09-22 13:49 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    During the recent solar eclipse, I:









    Results (264 votes). Check out past polls.

    Notices?