Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation

Re: Code review on script site

by demerphq (Chancellor)
on Nov 24, 2001 at 20:59 UTC ( #127272=note: print w/replies, xml ) Need Help??

in reply to Code review on script site

Regarding the style issue, I think you need to be careful. As has been pointed out in the subthread starting at Re: Re: Code review style is matter of opinion, often passionate, but at the same time has important side effects. Nevertheless the existance of a powerful formating tool such as perltidy makes some of these points redundant.

Personally I would would come up with a standard configuration for perltidy and then run all scripts through it prior to evaluation, and also publishing. This ensures that all scripts are of a uniform indentation and formatting style. Which leaves stylistic evaluation the more import issues such as as the use of obfu'd constructs, map in void context, stringification habits, commenting habbits, variable naming but exclude the more trivial (on the low level of correctness that is) and personal issues such as brace positioning and indentation size.

Yves / DeMerphq
Have you registered your Name Space?

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://127272]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (3)
As of 2017-11-18 22:01 GMT
Find Nodes?
    Voting Booth?
    In order to be able to say "I know Perl", you must have:

    Results (278 votes). Check out past polls.