Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris
 
PerlMonks  

Re: Fabric calculator - a better way to do it?

by jynx (Priest)
on Dec 06, 2001 at 09:36 UTC ( #129858=note: print w/replies, xml ) Need Help??


in reply to Fabric calculator - a better way to do it?


A few suggestions,

Most of these are rather cosmetic, but they should help readability.

Considering how many times you read from STDIN you may want to farm that part out to a subroutine. It would remove clutter from the rest of the code and should be a bit more maintainable later.

For structures like %width an array seems to make more sense than a hash. It works either way, but it's probably a good idea to try and use more appropriate tools when possible.

Also you can reduce the number of variables you have to keep track of by using a hash for multiple things. For example, your $number_of_* variables in the last section could probably be written as (using a subroutine for getting STDIN):

my %number; $number{blocks} = get_input("How many blocks are you making?"); $number{strips} = int( $total_pieces / $number_per_fabric_width_strip) +; etc...
jynx

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://129858]
help
Chatterbox?
[TStanley]: I'm sitting in the airport in Tampa, Florida at the moment, getting ready to head home.
[talexb]: TStanley I'm flying to Vegas in two weeks time. After that flights leaving Vegas and Phoenix are late at night .. I've been hearing that it gets so hot that the air isn't dense enough for planes to take off. Weird. Guess you won't have that problem.

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (10)
As of 2017-06-23 14:13 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    How many monitors do you use while coding?















    Results (548 votes). Check out past polls.